Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LoggerAwareTrait from Psr/Log #327

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Use LoggerAwareTrait from Psr/Log #327

merged 1 commit into from
Jul 19, 2024

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Jul 18, 2024 •
edited
Loading

This PR fixes PR #315 CS issue causing the tests to fail

escopecz
escopecz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd wait for a second review to merge this but I'm afraid we'd be waiting for a long time. Thank you!

@escopecz escopecz added this to the 4.0 milestone Jul 19, 2024
@escopecz escopecz merged commit 622e15f into mautic:main Jul 19, 2024
2 checks passed
@escopecz escopecz mentioned this pull request Jul 19, 2024
Closed
@matbcvo matbcvo deleted the psr-logger branch July 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matbcvo @escopecz