Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth Authorization #217

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Fix OAuth Authorization #217

merged 2 commits into from
Oct 10, 2020

Conversation

wise-gorilla
Copy link
Contributor

This edit fix the oAuth issue that raised when changed the POST to use json_encode instead of http_build_query #216

This edit fix the oAuth issue that raised when changed the POST to use  json_encode instead of http_build_query mautic#216
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍
@dennisameling Could we release new version? This is issue with Oauth2 and it's strange

@dennisameling
Copy link
Member

@kuzmany Absolutely. Not sure why Travis is failing; will take a look during the weekend 👍

@kuzmany
Copy link
Member

kuzmany commented Aug 20, 2020

@dennisameling We should merge this fix or #218 to master
A lot of people download master or last package and doesn't work for them.

@dennisameling
Copy link
Member

@kuzmany This needs a bit of work to fix for M3, there is even a special branch for M3 which hasn't been released yet https://github.com/mautic/api-library/tree/3.0 🤦🏼‍♂️ I was planning to release a new version of the API library on Monday together with the 3.1 release, as some fixes will need to be done to the automated tests first. To be continued; thanks for the heads-up!

@dennisameling
Copy link
Member

/cla-bot check

@RCheesley
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 10, 2020
@cla-bot
Copy link

cla-bot bot commented Oct 10, 2020

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@dennisameling
Copy link
Member

Thanks @wise-gorilla - merging this for the V3 release of the API library 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants