Added leetcode to socials and tried to implement github username changing #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: src/assets/icons/social/leetcode/default.svg
modified: src/resources/social_icons.ts
Trying to add the ability to change the github username in the stats layout tab
modified: src/features/stats/panel/views/layout/fields.ts
|
@yajatkaul is attempting to deploy a commit to the Mauro de Souza's projects Team on Vercel. A member of the Team first needs to authorize it. |
maurodesouza
requested changes
Mar 12, 2025
There was a problem hiding this comment.
I didn't understand why you changed the yarn.lock. Please remove this file from PR.
There was a problem hiding this comment.
The package management used in this project is yarn. Please remove this file from PR.
There was a problem hiding this comment.
A panel needs to be created to change the user config, and there should be an input to update the GitHub username. I understood the problem related to the GitHub username, but this is not the right place to edit it.
These changes can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes i made for leetcode
Changes i made for Github username changing ability
What type of PR is this? (check all applicable)
What I did
I was unable to do the github username thing since the code was very deep