Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am Michael and I am using wrenbind17 (thanks for providing it).
This is my first contribution to make it an even better library (others may follow ;-) ):
I noticed that std::realloc is called inside reallocateFn even if the size is 0.
According to C++ standard ( https://en.cppreference.com/w/cpp/memory/c/realloc ),
the behavior in that case in implementation defined and its usage is discouraged.
Instead it is recommend to call std::free instead (which is also the default implementation inside wren).
Please find my merge request that improves the code in this regard.
Best regards
Michael