Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakup ImageWidget into two Objects #25

Closed
mattrussmill opened this issue Jun 28, 2018 · 5 comments
Closed

Breakup ImageWidget into two Objects #25

mattrussmill opened this issue Jun 28, 2018 · 5 comments
Assignees

Comments

@mattrussmill
Copy link
Owner

mattrussmill commented Jun 28, 2018

ImageWidget needs to be broken up into multiple cpp files. Too large

@mattrussmill
Copy link
Owner Author

mattrussmill commented Feb 7, 2019

objects should be broken up so that it contains sub objects and these sub objects contain the functionality that pertains only to those objects. (e.g. mousemoveevent should be specific to widget, not if(within roi) - e.g. overload QLabel to add mouse operations shared for all image displays which would help break up ImageWidget into smaller parts)

@mattrussmill mattrussmill changed the title Breakup Image Worker Breakup Image Worker and Objects Feb 17, 2019
@mattrussmill
Copy link
Owner Author

mattrussmill commented Feb 23, 2019

Potentially tie each section in worker thread to smaller workers that are created and destroyed when menus are switched? e.g. all transform operations in transformWorker? Easier to handle data back and forth between objects that need to. - see Wiki for notes.

@mattrussmill
Copy link
Owner Author

imagewidget should have a base class that overrides QLabel for the necessary paint events (drawing ROI select and Brush) which would be MUCH faster than its current implementation. - Later break this up into individual projects.

@mattrussmill
Copy link
Owner Author

mattrussmill commented Mar 5, 2019

ImageWorker is being broken up accordingly. This functionality solves several problems with the application both in performance and backend organization. ImageWidget should be broken up so that he QLabel contains all drawing and mouse tracking functionality to both speed up painting by painting directly on the widget (usually not a great practice unless justified). This can be broken up even further so that there is an intermediate QLabel that handles mouse tracking which can also be used in the QColorSelector.

Maybe the QLabels could be modular like the imageWorkers, and attached in the widget accordingly, containing the proper drawing functionality specific to the selected menu.

This should be in the second release of the application. For now get the first version done.

@mattrussmill mattrussmill changed the title Breakup Image Worker and Objects Breakup ImageWidget into two Objects Mar 5, 2019
@mattrussmill
Copy link
Owner Author

mattrussmill commented Mar 5, 2019

Maybe this can be more simply achieved through event filters! If not perhaps, streamline the function calls and paint on the pixmap before attaching it to the QLabel.

(try the event filters at least to simplify mouse operations)

mattrussmill added a commit that referenced this issue Sep 8, 2019
…or cursor tracking in image implemented in image widget. to be transferred to event filter for #25 later.
mattrussmill added a commit that referenced this issue Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant