Support passing of regex and functions to Go #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also execute `go install` after building
Previously arguments being passed to Go via an AddFunc callback were marshalled to JSON first. This is still the case for values other than regular expressions or functions. Regexes are now wrapped in a Go *RegExp, while functions are wrapped in a custom V8Function object, which supports calling the function in the originating V8 context with the supplied arguments.
|
Awesome. Thank you. |
mattn
added a commit
that referenced
this pull request
Feb 13, 2013
Support passing of regex and functions to Go
|
It seems that can't compile on windows. |
|
Ah, and I don't have a Go environment set up on Windows at the moment. :/ Also I forgot to run the tests. They'll probably be failing as well... 😢 |
|
Fixed it just now. :) |
|
I want to change |
v8ctx.AddFunc("func_call", func(args ...interface{}) interface{} {
ret, _ := args[0].(v8.V8Function).Call("\"Golang\"")
return ret
})
fmt.Println(v8ctx.MustEval(`
func_call(function() {
return "hello " + arguments[0];
})
`).(string))I want to fix: v8ctx.AddFunc("func_call", func(args ...interface{}) interface{} {
ret, _ := args[0].(v8.V8Function).Call("Golang", 1, 2 3)
return ret
})
fmt.Println(v8ctx.MustEval(`
func_call(function() {
return "hello " + arguments[0] + (arguments[1] + arguments[2] + arguments[3]);
})
`).(string)) |
|
Sure, I should be able to look at it tomorrow. |
mattn
added a commit
that referenced
this pull request
Aug 19, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #8, #9