Skip to content

Conversation

@realPy
Copy link

@realPy realPy commented Mar 21, 2021

Mac os compilation work with --tags="darwin libsqlite3" but not with --tags=darwin because assert is not defined with clang.
This PR correct this bug and now libsqlite3 can be included static (not only link with the libsqlite3).
I have also update the almagation to the latest 3.35.2 version

@codecov-io
Copy link

codecov-io commented Mar 21, 2021

Codecov Report

Merging #929 (976f046) into master (ab91e93) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   46.80%   46.80%           
=======================================
  Files          11       11           
  Lines        1457     1457           
=======================================
  Hits          682      682           
  Misses        640      640           
  Partials      135      135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab91e93...976f046. Read the comment docs.

@mattn
Copy link
Owner

mattn commented Jul 15, 2021

Thank you. I hope to update alamagation code my self. I'll merge your few commits in this PR in later.

@realPy realPy changed the title Update almagation 3.35.2 and correct mac OS problem compilation Update almagation 3.36 and correct mac OS problem compilation Jul 15, 2021
@realPy
Copy link
Author

realPy commented Jul 15, 2021

just sync my project with your repo and update to almagation 3.36.

@mattn mattn mentioned this pull request Jul 15, 2021
@mattn
Copy link
Owner

mattn commented Jul 15, 2021

Addressed in #955

Why did you squashed or removed some commits for macOS?

@realPy
Copy link
Author

realPy commented Jul 15, 2021

Because some of your tag and commit was missing in my fork.
I just get a clean copy of your work and apply a patch

@realPy
Copy link
Author

realPy commented Jul 15, 2021

to correct macos native compilation (embbed in executable)
the 3 lines next is need in sqlite3-binding.c (at head)

#ifdef __clang__
#define assert(condition) ((void)0)
#endif 

@mattn
Copy link
Owner

mattn commented Jul 15, 2021

Could you please try #955 ? #955 include your patch to generator of amalgamation codes.

@realPy
Copy link
Author

realPy commented Jul 15, 2021

Yes :) i will

@realPy
Copy link
Author

realPy commented Jul 15, 2021

It's ok for me , all my test unit passed sucessfull passed with #955

@mattn mattn closed this in #955 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants