Implement support for calling Go functions from SQLite #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, awesome. I'll look into it in later. |
…ndling. A call now doesn't have to do any reflection, it just blindly invokes a bunch of argument and return value handlers to execute the translation, and the safety of the translation is determined at registration time.
Currently, the variadic part must all be the same type, because there's no "generic" arg converter.
This enabled support for functions like Foo(a interface{}) and
Bar(a ...interface{}).
|
Ping? |
|
I'll merge this after CI. 👍 |
|
Could you handle error on CI? |
|
Sorry, there was a typo in one of the tests. Fixed and repushed, CI passes now. |
mattn
added a commit
that referenced
this pull request
Sep 16, 2015
Implement support for calling Go functions from SQLite
|
Coooooooooool! 👍 |
|
This is slick. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226.
Supports scalar functions and aggregation functions.
I've benchmarked the call stack, and even with the reflection, the performance matches the QueryRow benchmark (18 microseconds per "SELECT custom_func(1,2)").