Runewidth speedup #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that future optimizations don't break functionality.
This results in a 6x speedup for the common case RuneWidth768. name old time/op new time/op delta RuneWidth768-4 21.5µs ± 0% 2.7µs ± 0% -87.27% (p=0.029 n=4+4) RuneWidthAll-4 51.1ms ± 0% 45.3ms ± 0% -11.38% (p=0.029 n=4+4) String1Width768-4 219µs ± 2% 198µs ± 2% -9.73% (p=0.029 n=4+4) RuneWidth768EastAsian-4 35.6µs ± 0% 34.2µs ± 0% -3.86% (p=0.029 n=4+4) RuneWidthAllEastAsian-4 71.5ms ± 0% 69.1ms ± 0% -3.26% (p=0.029 n=4+4) String1WidthAll-4 356ms ± 1% 353ms ± 2% ~ (p=0.343 n=4+4) String1WidthAllEastAsian-4 378ms ± 1% 378ms ± 2% ~ (p=0.886 n=4+4) String1Width768EastAsian-4 236µs ± 1% 235µs ± 2% ~ (p=0.886 n=4+4) [Geo mean] 3.44ms 2.56ms -25.63%
|
This results in a 6x speedup for the common case RuneWidth768. |
|
How does this compare with #42? |
Should be about the same. Once this request is merged more micro-optimizations can easily be made because of the new benchmarks. |
|
Could you please resolve conflicts? |
|
Will do, but please fix the master branch first - commit c9bd7d1 seems broken. |
|
I merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.