Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust build tags to allow building on tinygo; for #73. #74

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dkegel-fastly
Copy link
Contributor

Passes "tinygo test" on macos and linux.
Passes cross test to windows from macos, i.e. "GOOS=windows tinygo test -c; wine64 go-isatty.test".

Had to adjust the build tags on isatty_others.go to avoid multiple definition link failure on

$ GOOS=windows tinygo test

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #74 (9bb614f) into master (cdb00f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files           3        3           
  Lines          75       75           
=======================================
  Hits           33       33           
  Misses         40       40           
  Partials        2        2           
Impacted Files Coverage Δ
isatty_bsd.go 100.00% <ø> (ø)
isatty_tcgets.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb00f1...9bb614f. Read the comment docs.

@rajatjindal
Copy link

Hi @mattn

is it possible to get this merged so that we can use this with tinygo?

@mattn
Copy link
Owner

mattn commented May 20, 2023

could you please fix conflict?

@rajatjindal
Copy link

Hi @dkegel-fastly thank you for fixing the conflict.

@mattn over to you now :), thank you so much.

@rajatjindal
Copy link

Hi @mattn , a kind reminder. thank you.

@rajatjindal
Copy link

a kind reminder @mattn, thank you.

@rajatjindal
Copy link

Hi @mattn , a kind reminder to kindly review the PR. once merged, it will allow folks, using tinygo, to stop using the fork.

many thanks in advance.

@dkegel-fastly
Copy link
Contributor Author

Yes, please!

@dkegel-fastly
Copy link
Contributor Author

tinygo-0.28 is coming out shortly, which will bring more users hoping for this fix, I think!

@ydnar
Copy link

ydnar commented Oct 17, 2023

Hi @mattn, another request to merge @dkegel-fastly’s PR. Ran into this issue today with TinyGo. Many thanks!

@mattn mattn merged commit a7c0235 into mattn:master Oct 17, 2023
@mattn
Copy link
Owner

mattn commented Oct 17, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants