Disable keep-alives on shutdown.

See also: knative#1509 (comment)
mattmoor · Jul 16, 2020 · 71db0b6 · 71db0b6
1 parent 25f2aa6
commit 71db0b6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/webhook/webhook.go b/webhook/webhook.go
@@ -219,6 +219,9 @@ func (wh *Webhook) Run(stop <-chan struct{}) error {
 			logger.Info("Starting to fail readiness probes...")
 			close(wh.stopCh)
 
+			// As we start to shutdown, disable keep-alives to avoid clients hanging onto connections.
+			server.SetKeepAlivesEnabled(false)
+
 			// Wait for a grace period for the above to take effect and this Pod's
 			// endpoint to be removed from the webhook service's Endpoints.
 			// For this to be effective, it must be greater than the probe's