Sloooooow object return

[ThePoShWolf]

Hey! Great module, by the way.

I've only tested this with Get-OneLoginUser, but it appears that most of the cmdlets have the same issue.

Since Invoke-OneLoginRestMethod @Splat is wrapped in (), it enumerates all the return objects before converting them. This causes any pipeline actions to have to wait for the entire array of objects before doing anything, which kind of defeats the purpose of using the pipeline.

Is there a reason for this?

Here is a good example of the difference, this is the command without any modifications:

Measure-Command {Get-OneLoginUser -All | Select-Object -First 1}

On average, that was taking 25-30 seconds to complete in my environment, which was actually the same amount of time as without piping to Select-Object.

If I were to adjust line 60 to be:

Invoke-OneLoginRestMethod @Splat | ConvertTo-OneLoginObject -OutputType $OutputType

Then running the same command:

Measure-Command {Get-OneLoginUser -All | Select-Object -First 1}

Takes less than one second since Invoke-OneLoginRestMethod @Splat halts after passing the first object down the pipeline.

[ThePoShWolf]

If this is something that doesn't have any particular reason for being done this way, I'm happy to go through, make the modifications, test, and submit a PR. Just let me know.

[mattmcnabb]

@ThePoShWolf What version of PowerShell are you using? I haven't seen this performing super slowly so far, but I don't a ton of users in my dev tenant (900-ish).

This is done because of a quirk in how the Web cmdlets are implemented in Windows PowerShell. Essentially when objects are returned in json and converted to .net objects, they are not enumerated and you actually get one object passed down the pipeline. Adding parens is a workaround that enumerates them for pipeline processing.

So I'm thinking the performance hit might be because the returned objects are being unrolled in the scope of the public function, and I'm wondering if it might work better to unroll each page of results inside Invoke-OneLoginRestMethod? I think that I might have tried that in the past and couldn't come to a working solution but I can take a look again.

I'm thinking that this may not be an issue in PowerShell 7 so I wonder if some custom logic could be implemented to make this perform differently based on the $PSVersionTable variable.

[ThePoShWolf]

I was using it in Windows PS 5.1. I attempted to load the module in 7, but hit an error when running Connect-OneLogin, something I want to revist when I have some more time.

And thats interesting, I didn't know that about the web cmdlets. Do you know what version of Windows PS that is applicable to? I ask because removing the () doesn't appear to have any negative effect. While in Windows PS 5.1, I removed the () in Get-OneLoginUser, reloaded the module, and got the same nicely formatted output as before. That time, however, each object output as it was returned instead of waiting until the very end to dump them all at once.