correct issue with validator failing on class alias as typehint. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthias\SymfonyServiceDefinitionValidator\Functional\FunctionalTest::testIfTheServiceDefinitionsAreCorrectTheContainerWillBeCompiled Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Invalid key "dsn" found in arguments of method "__construct()" for service "pdo": only integer or $named arguments are allowed.
|
@matthiasnoback this is the same as the code from #44 without the extra stuff. I did have to correct another issue in the pdo config (3da9e51) in order to get the test to pass. Sadly #39 still prevents zikula from using the latest version of this lib. I've cobbled together a version which use 1.2.6 + these commits and that works for us at the moment. |
|
Thanks, too bad you didn't mark me as author of commits but let's go with this ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43.
all code written by @stloyd refs #44