Reject empty bullets option with a clear error#268
Open
santhreal wants to merge 1 commit into
Open
Conversation
An empty bullets sequence (e.g. bullets='' or bullets=[]) made convert_li evaluate bullets[depth % len(bullets)], raising an opaque ZeroDivisionError deep in unordered-list conversion. Validate it at construction and raise a clear ValueError, matching the existing strip/convert check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
bulletsoption ('',[], or()) makesconvert_lievaluatebullets[depth % len(bullets)], which raises an opaqueZeroDivisionErrordeep in unordered-list conversion the first time a list is converted (construction succeeds, so the cause is hard to spot).This validates
bulletsat construction and raises a clearValueError, matching the existing strip/convert check. Non-empty bullets (str or list) are unaffected.Added
test_empty_bullets_rejectedandtest_non_empty_bullets_still_acceptedin tests/test_args.py.