-
Notifications
You must be signed in to change notification settings - Fork 278
Import force/smart_str instead of force/smart_text #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This doesn't seem like the cleanest fix, and it feels like the backwards compatibility with Django 1.5 might not be necessary. But I'm unsure of the Django/Python support policy of this project. I noticed that the tox and travis configs only test fairly old Django versions, which surprised me. |
|
Because after the merge of #536 we are testing Django 2.2+ and Python 3.6+ we can assume that we can remove some compatibility shims in order to cleanup the code base. Do you think that this PR is a good candidate for that or another one which will do a full dissection of the whole project? |
@vstoykov I'd rather get this merged and a patch release on PyPI before gutting all the historic compatibility code. |
If we do a patch release this means that it should support Python 2 and proposed changes will probably break something on Python 2. This is my gut feeling because I'm not sure that it is tested correctly. With the changes that are already merged we do not test old versions of Django and Python. This means that we are droping support for that. If we are dropping the support probably now is the time to cleanup the code base and release version 5 of ImageKit. What you think? |
force_text and smart_text were deprecated in Django 3.0 and are removed in Django 4.0
I've added Python 2.7 back to the tests and restored compatibility (in the tests only, the codebase remained compatible). Had to pin django-appconf for Python 2.7 as the recent release is not compatible with Python 2. Django 1.11 is also the only version tested on Python 2.7 as future Django versions dropped Python 2 support. |
force_text and smart_text were deprecated in Django 3.0 and are removed in Django 4.0
force_text and smart_text were deprecated in Django 3.0 and are removed in Django 4.0