#473 fix for 'seek of closed file' Error #517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f.file", then seek to start of file handle, and then "self.storage.save" (which will result in a closed file handle, from which we can no longer seek nor read)
|
Thank you for your contribution! Can I ask if you can add a test that will fail if the fix is not applied? Thank you. |
|
I saw a recent new update for this package but unfortunately this didn't make the cut? :( |
julianwachholz
added a commit
to julianwachholz/django-imagekit
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to change the order here, first populate "self.file", then seek to start of file handle, and then "self.storage.save" (which will result in a closed file handle, from which we can no longer seek nor read)