Concurrent user issue #8

matthewturner · 2019-03-28T06:43:41Z

No description provided.

houndci-bot · 2019-03-28T06:43:44Z

thermostats/Salus.js

+
+    async logout() {
+        console.log('Logging out...');
+        await request.get(this.urlTo('logout', false), { jar: this._jar});


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

houndci-bot · 2019-03-28T06:43:44Z

thermostats/Salus.js

+        await request.post(`${host}/includes/set.php`, options);
+    }
+
+    async logout() {


Class properties must be methods. Expected '(' but instead saw 'logout'.
Duplicate class method 'async'.

houndci-bot · 2019-03-28T06:43:44Z

thermostats/Salus.js

        };

-        await request.post(`${host}/includes/set.php`, form);
+        await request.post(`${host}/includes/set.php`, options);


'template literal syntax' is only available in ES6 (use 'esversion: 6').
Expected an assignment or function call and instead saw an expression.
Missing semicolon.

houndci-bot · 2019-03-28T06:43:44Z

thermostats/Salus.js

        console.log(`Setting temp: ${t}...`);
-        let form = {
+        let options = {


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:43:44Z

thermostats/Salus.js

@@ -79,19 +79,25 @@ class Salus {
    }

    async setTemperature(temp) {
-        let t = parseFloat(temp).toFixed(1);
+        let t = temp.toFixed(1);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:43:45Z

google/lambda.js

+const handler = async (event) => {
+    console.log(event);
+    let onOff = event.queryResult.parameters.onOff;
+    let duration = event.queryResult.parameters.duration.amount;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:43:46Z

google/lambda.js

+
+const handler = async (event) => {
+    console.log(event);
+    let onOff = event.queryResult.parameters.onOff;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:43:46Z

google/lambda.js

+};
+
+const handler = async (event) => {
+    console.log(event);


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected ')' to match '{' from line 40 and instead saw '.'.

houndci-bot · 2019-03-28T06:43:46Z

google/lambda.js

+    return m;
+};
+
+const handler = async (event) => {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Expected '(' and instead saw '{'.

houndci-bot · 2019-03-28T06:43:46Z

google/lambda.js

+const say = (messages) => {
+    var m = '';
+    if (messages instanceof Array) {
+        for (const message of messages) {


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'for of' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:47:43Z

google/lambda.js

+        return {
+            fulfillmentText: say(e)
+        };
+    }


Unrecoverable syntax error. (92% scanned).

houndci-bot · 2019-03-28T06:47:43Z

google/lambda.js

+};
+
+const handler = async (event) => {
+    console.log(event);


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected ')' to match '{' from line 22 and instead saw '.'.

houndci-bot · 2019-03-28T06:47:43Z

google/lambda.js

+const Factory = require('../thermostats/Factory');
+
+const say = (messages) => {
+    let m = '';


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:47:44Z

google/lambda.js

+const ControlService = require('../core/ControlService');
+const Factory = require('../thermostats/Factory');
+
+const say = (messages) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:47:44Z

google/lambda.js

+const AwsHoldStrategy = require('../aws/HoldStrategy');
+const DefaultHoldStrategy = require('../core/HoldStrategy');
+const ControlService = require('../core/ControlService');
+const Factory = require('../thermostats/Factory');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T06:47:45Z

core/ThermostatRepository.js

-            }
+            },
+            defaultOnTemp: parseFloat(process.env.DEFAULT_ON_TEMP || '20'),
+            defaultOffTemp: parseFloat(process.env.DEFAULT_OFF_TEMP || '14'),


'process' is not defined.

houndci-bot · 2019-03-28T06:47:45Z

core/ThermostatRepository.js

@@ -13,7 +13,10 @@ class ThermostatRepository {
            options: {
                username: process.env.USERNAME,
                password: process.env.PASSWORD
-            }
+            },
+            defaultOnTemp: parseFloat(process.env.DEFAULT_ON_TEMP || '20'),


'process' is not defined.

houndci-bot · 2019-03-28T06:47:45Z

core/ControlService.js

+            let messages = [];
+            messages.push(`The current temperature is ${this.speakTemperature(device.currentTemperature)} degrees.`);
+            messages.push(`The target is ${this.speakTemperature(device.targetTemperature)} degrees.`);
+            await this.determineIfHolding(device, messages);


Expected an assignment or function call and instead saw an expression.
Too many errors. (33% scanned).

houndci-bot · 2019-03-28T06:47:45Z

core/ControlService.js

+
+            let messages = [];
+            messages.push(`The current temperature is ${this.speakTemperature(device.currentTemperature)} degrees.`);
+            messages.push(`The target is ${this.speakTemperature(device.targetTemperature)} degrees.`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2019-03-28T06:47:45Z

core/ControlService.js

+            this.verifyContactable(device);
+
+            let messages = [];
+            messages.push(`The current temperature is ${this.speakTemperature(device.currentTemperature)} degrees.`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2019-03-28T09:06:12Z

aws/ThermostatRepository.js

@@ -35,6 +35,7 @@ class ThermostatRepository {

        let response = await this.client.get(params).promise();
        if (response.Item) {
+            console.log(`Found thermostat for user ${userId} with username ${response.Item.options.username}`);


'console' is not defined.
'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2019-03-28T09:06:14Z

core/ControlService.js

+            let device = await client.device();
+            this.verifyContactable(device);
+
+            let messages = [];


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T09:06:14Z

core/ControlService.js

-        return messages;
+        try {
+            await this.verifyOnline(client);
+            let device = await client.device();


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

houndci-bot · 2019-03-28T09:06:15Z

core/ControlService.js

-        this.logStatus(device);
-        return messages;
+        try {
+            await this.verifyOnline(client);


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

houndci-bot · 2019-03-28T09:06:15Z

core/ControlService.js

+                return 'Sorry, the thermostat is offline at the moment.';
+            }
+        } finally {
+            await client.logout();


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

houndci-bot · 2019-03-28T09:06:15Z

core/ControlService.js

+        try {
+            if (await client.online()) {
+                return 'Thermostat is online';
+            } else {


Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw 'else'.
Missing semicolon.

houndci-bot · 2019-03-28T09:06:16Z

aws/lambda.js

+    console.log('*******************************');
+
+    let userId = request.userId || request.data.session.user.userId;
+    let source = 'user';


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T09:06:16Z

aws/lambda.js

+    }
+    console.log('*******************************');
+
+    let userId = request.userId || request.data.session.user.userId;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2019-03-28T09:06:16Z

aws/lambda.js

+    console.log('Context');
+    console.log(request.context);
+    if (request.data.context) {
+        console.log(`Deep UserId: ${request.data.context.System.user.userId}`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2019-03-28T09:06:16Z

aws/lambda.js

-    let context = { userId };
+const controlService = (request) => {
+    console.log('*******************************');
+    console.log(`UserId: ${request.userId}`);


'template literal syntax' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2019-03-28T09:06:16Z

aws/lambda.js

@@ -11,8 +11,25 @@ module.change_code = 0;

 let app = new alexa.app('boiler');

-const controlService = (userId) => {
-    let context = { userId };
+const controlService = (request) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot reviewed Mar 28, 2019

View reviewed changes

matthewturner added 5 commits March 28, 2019 09:05

Add logging for concurrent user

3143eb6

Fix to repeat turnoff issue

5f51236

Fix concurrency issue

c260820

cr

068c90f

dd

27c78d3

matthewturner force-pushed the concurrent-user-issue branch from b4155bc to 27c78d3 Compare March 28, 2019 09:06

houndci-bot reviewed Mar 28, 2019

View reviewed changes

Matt Turner and others added 4 commits March 28, 2019 09:15

d

9db66f9

d

139229c

d

611adcc

d

18376a6

matthewturner merged commit 32d216a into master Mar 28, 2019

matthewturner deleted the concurrent-user-issue branch March 28, 2019 17:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Concurrent user issue #8

Concurrent user issue #8

matthewturner commented Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

houndci-bot Mar 28, 2019

Concurrent user issue #8

Concurrent user issue #8

Conversation

matthewturner commented Mar 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment