S2a options set default LocalIdentity for ClientOptions

[davisgu]

This change is 

[Ryanfsdf]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @davisgu and @matthewstevenson88)

---

security/s2a/s2a_options.go, line 95 at r1 (raw file):

		return &s2apb.Identity{IdentityOneof: &s2apb.Identity_Hostname{Hostname: id.Name()}}, nil
	default:
		return nil, errors.New("unrecognized identity type")

I was thinking that instead of returning something in the default case, we should check at the very beginning of this function if the identity passed is nil and return return nil, nil in that case. WDYT?

[matthewstevenson88]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matthewstevenson88 and @Ryanfsdf)

---

security/s2a/s2a_options.go, line 95 at r1 (raw file):

Previously, Ryanfsdf (Ryan Kim) wrote…

I was thinking that instead of returning something in the default case, we should check at the very beginning of this function if the identity passed is nil and return return nil, nil in that case. WDYT?

+1.

We still want the error case when the type is unrecognized.

Also, please add a unit test that checks whatever code path we add.

[davisgu]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Ryanfsdf)

---

security/s2a/s2a_options.go, line 95 at r1 (raw file):

Previously, matthewstevenson88 wrote…

+1.

We still want the error case when the type is unrecognized.

Also, please add a unit test that checks whatever code path we add.

That makes sense abt the unrecognized type, but if the identity passed is nil, shouldn't we then return the default?

[davisgu]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Ryanfsdf)

---

security/s2a/s2a_options.go, line 95 at r1 (raw file):

Previously, davisgu wrote…

That makes sense abt the unrecognized type, but if the identity passed is nil, shouldn't we then return the default?

Done.

[matthewstevenson88]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Ryanfsdf)

[Ryanfsdf]

Reviewable status: 0 of 2 files reviewed, all discussions resolved