Fix S2A E2E greeter client #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewstevenson88
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
I've approved, but we need to make the fixes to s2a_options.go so that the e2e tests work even if no local identity is set. (It will be fairly common use case that the local identity is not set.)
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @matthewstevenson88)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the S2A E2E greeter client by adding a local identity as well as fixing the response message string comparison.
This change is