Skip to content

Commit

Permalink
Clarify IE11 support
Browse files Browse the repository at this point in the history
  • Loading branch information
alexdima committed Feb 13, 2020
1 parent c299715 commit 916bd49
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ It is recommended to develop against the `dev` version, and in production to use

Create [issues](https://github.com/Microsoft/monaco-editor/issues) in this repository for anything related to the Monaco Editor. Always mention **the version** of the editor when creating issues and **the browser** you're having trouble in. Please search for existing issues to avoid duplicates.

## Known issues
In IE 11, the editor must be surrounded in the body element, otherwise the hit testing performed for mouse operations does not work. You can inspect this using F12 and click on the body element and confirm that visually it surrounds the editor.

## FAQ

**What is the relationship between VS Code and the Monaco Editor?**
Expand Down Expand Up @@ -87,6 +84,10 @@ No.
* We have experimented with Emscripten to compile the C library to asm.js, but performance was very poor even in Firefox (10x slower) and extremely poor in Chrome (100x slower).
* We can revisit this once WebAssembly gets traction in the major browsers, but we will still need to consider the browser matrix we support, i.e. if we support IE11 and only Edge will add WebAssembly support, what will the experience be in IE11, etc.

**What about IE 11 support?**

* The Monaco Editor no longer supports IE 11. The last version that was tested on IE 11 is `0.14.0`.

## Development setup

Please see [CONTRIBUTING](./CONTRIBUTING.md)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
});

// Explanation:
// Press F1 (Alt-F1 in IE) => the action will appear and run if it is enabled
// Press F1 (Alt-F1 in Edge) => the action will appear and run if it is enabled
// Press Ctrl-F10 => the action will run if it is enabled
// Press Chord Ctrl-K, Ctrl-M => the action will run if it is enabled

Expand Down Expand Up @@ -92,4 +92,4 @@
});
</script>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion website/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ <h3>About</h3>
<p>The Monaco Editor is the code editor that powers <a href="https://github.com/Microsoft/vscode">VS Code</a>.
A good page describing the code editor's features is <a href="https://code.visualstudio.com/docs/editor/editingevolved">here</a>.</p>

<p>It is licensed under the MIT License and supports IE 11, Edge, Chrome, Firefox, Safari and Opera.</p>
<p>It is licensed under the MIT License and supports Classic Edge, Edge, Chrome, Firefox, Safari and Opera.</p>

<p>The Monaco editor is <span style="font-weight:bold;color:#ff5722;">not</span> supported in mobile browsers or mobile web frameworks. </p>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var editor = monaco.editor.create(document.getElementById("container"), {
});

// Explanation:
// Press F1 (Alt-F1 in IE) => the action will appear and run if it is enabled
// Press F1 (Alt-F1 in Edge) => the action will appear and run if it is enabled
// Press Ctrl-F10 => the action will run if it is enabled
// Press Chord Ctrl-K, Ctrl-M => the action will run if it is enabled

Expand Down

0 comments on commit 916bd49

Please sign in to comment.