fix comment in DetectionTargetLayer #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedka
requested changes
Sep 28, 2018
mrcnn/model.py
Outdated
| @@ -576,7 +575,7 @@ def detection_targets_graph(proposals, gt_class_ids, gt_boxes, gt_masks, config) | |||
| deltas /= config.BBOX_STD_DEV | |||
|
|
|||
| # Assign positive ROIs to GT masks | |||
| # Permute masks to [N, height, width, 1] | |||
| # Permute masks to [MAX_GT_INSTANCES, height, width, 1] | |||
There was a problem hiding this comment.
gt_masks gets filtered above, so by the time you get to this point, N != MAX_GT_INSTANCES.
|
@waleedka I have changed it back to N. |
Cpruce
pushed a commit
to Cpruce/Mask_RCNN
that referenced
this pull request
Jan 17, 2019
* fix comment in DetectionTargetLayer * fix comment of target_deltas' shape * make parenthesis compatible
aneeshchauhan
pushed a commit
to aneeshchauhan/Mask_RCNN
that referenced
this pull request
Jul 9, 2019
* fix comment in DetectionTargetLayer * fix comment of target_deltas' shape * make parenthesis compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.