Fix Keras engine module topology to saving #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this cause an issue on Keras version earlier than 2.2? |
|
Nope, But most are using Keras latest version and Keras notices that topology module is deprecated. |
|
Got the same problem. It seems Keras default pip3 version does not support topology any-more. |
This was referenced Jun 20, 2018
kheffah
added a commit
to kheffah/Mask_RCNN
that referenced
this pull request
Jun 29, 2018
…atterport#662 in the upstream repo from matterport
LackesLab
approved these changes
Jul 2, 2018
|
Actually, this does break the code on earlier versions of Keras. >>> keras.__version__
'2.1.6'
>>> from keras.engine import saving
ImportError: cannot import name 'saving'I'll merge it, and then add a check to handle older versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #566