Open
Conversation
added 4 commits
December 28, 2021 12:27
allows a way to get overall progress via traverse
Maybe? So far I have needed to duplicate the majority of this functionality in order to work with my custom extension? Is it too much to export the utility functions from the package as a way to keep internal/cached properties from being relied upon by external package users / exposed via types?
bzztbomb
approved these changes
Jan 4, 2022
Collaborator
bzztbomb
left a comment
bzztbomb
left a comment
There was a problem hiding this comment.
Looks good!
Naming suggestions are little nits, but I think they would be a bit more clear.
|
|
||
| // Convert 3d-tiles boundingVolume optional definitions into concrete THREE box/sphere/matrix description | ||
| // - ex: used in 'tile.cached' | ||
| export function convertTileBoundingVolume( boundingVolume: TileBase['boundingVolume'], transform: Matrix4 ): BoundingVolumeDescriptor; |
Collaborator
There was a problem hiding this comment.
Maybe this should be convertBoundingVolumeToBox3 to match the function below? Or maybe just boundingVolumeToBox3 to be shorter?
| import type { TileBase } from '../base/TileBase'; | ||
|
|
||
| // Convert optional 3d-tiles transform object into a THREE.Matrix4 | ||
| export function convertTileTransform( transform: TileBase['transform'], parentMatrix: Matrix4 ): Matrix4; |
Collaborator
There was a problem hiding this comment.
Maybe tileTransformToMatrix4 is a bit clearer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[util] - expose isTileDownloadFinished as utility function
[util] - separate / share-able 3d-tiles -> three conversion utils
It seemed slightly nicer to export a set of utility functions from the package as a way to keep the tile internal/cached properties from being relied upon by external package users / exposed via types?