-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize remaining strings #198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=========================================
+ Coverage 96.22% 96.33% +0.1%
=========================================
Files 12 12
Lines 822 846 +24
=========================================
+ Hits 791 815 +24
Misses 20 20
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current architecture is fine for me, and naming ErrorMessage
is the best for now.
I left one more comment, so please take a look it.
This PR localizes the last few remaining strings. It does that by adding a
poll.ErrorMessage
struct (0/5 on the naming). This message is meant for a user to consume and should not be wrapped.I would love to hear feedback on the design.
Fixes #196