Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

fix Dm name in file preview modal info bar #9547

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

AshishDhama
Copy link
Contributor

Summary

File preview modal info bar has channel id instead of channel name for DM's

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-40460

Related Pull Requests

NONE

Screenshots

before after
Image Pasted at 2021-12-2 21-04 Screenshot 2021-12-20 at 12 26 34 PM

Release Note

* File preview modal info bar has channel id instead of channel name for DM's

@AshishDhama AshishDhama self-assigned this Dec 20, 2021
@AshishDhama AshishDhama added 2: Dev Review Requires review by a core commiter QA Deferred Agreement with QA that these changes will be tested post-merge labels Dec 20, 2021
@AshishDhama AshishDhama force-pushed the MM-40460_DM-channel-name-in-file-preview-modal branch from a5b82d3 to 2e42917 Compare December 20, 2021 07:10
@ashishbhate ashishbhate removed the 2: Dev Review Requires review by a core commiter label Dec 21, 2021
@Willyfrog Willyfrog merged commit 807e2d8 into master Dec 22, 2021
@Willyfrog Willyfrog deleted the MM-40460_DM-channel-name-in-file-preview-modal branch December 22, 2021 10:23
@amyblais amyblais added this to the v6.3.0 milestone Dec 22, 2021
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Dec 22, 2021
@amyblais amyblais modified the milestones: v6.3.0, v6.4.0 Dec 22, 2021
@amyblais amyblais removed Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Dec 22, 2021
@mattermost mattermost deleted a comment from mattermod Dec 22, 2021
@mattermost mattermost deleted a comment from mattermod Dec 22, 2021
M-ZubairAhmed pushed a commit that referenced this pull request Dec 25, 2021
use state.show & top level onExited for invitation modal (#9550)

[MM-40407] - Do not show the Renew Now if the license id does not exist in the portal (#9544)

* [MM-40407] - Do not show the Renew Now if the license id does not exist in the portal

* fix translation strings

* add unit test

* improvements

MM-40600 - use custom type and set correct value to api response (#9546)

Automatic Merge

MM-40218 - start trial from team edition, do upgrade and request license (#9454)

* MM-40218 - start trial from team edition, do upgrade and request license

* add i18n texts

* fix snapshots

* show restarting text and define which button was clicked

* prevent the preference to get saved

* hide the update and request trial banner if normal button is clicked

* fix tests and snapshots

MM-40114/MM-40545 Clean up MobileSidebarHeader and have it use getIsMobileView (#9512)

* MM-40114 Clean up LegacySidebarHeader and remove usage of Utils.isMobile

* MM-40114 Rename LegacySidebarHeader to MobileSidebarHeader and remove unused dropdown

* MM-40545 Fix Account Settings shortcut in desktop view

* Apply suggestions from code review

Co-authored-by: Jelena Gilliam <52937121+jgilliam17@users.noreply.github.com>
Co-Authored-By: Pablo Velez Vidal <pablo.velez@mattermost.com>
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation QA Deferred Agreement with QA that these changes will be tested post-merge release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants