Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-17517 Remove ambiguity on LDAP and SAML System Console help texts #3362

Merged
merged 3 commits into from
Aug 6, 2019
Merged

MM-17517 Remove ambiguity on LDAP and SAML System Console help texts #3362

merged 3 commits into from
Aug 6, 2019

Conversation

jasonblais
Copy link
Contributor

Summary

Updates help texts for the following fields, where the description was ambiguous on whether enabling or disabling the setting is not recommended for production

  • admin.ldap.skipCertificateVerificationDesc
  • admin.saml.encryptDescription
  • admin.saml.verifyDescription

Ticket Link

https://mattermost.atlassian.net/browse/MM-17517

Related Pull Requests

None

@jasonblais jasonblais added the 1: PM Review Requires review by a product manager label Aug 5, 2019
@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 5, 2019
wiersgallak
wiersgallak approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wiersgallak wiersgallak removed the 1: PM Review Requires review by a product manager label Aug 5, 2019
@lieut-data lieut-data removed the 2: Dev Review Requires review by a core commiter label Aug 6, 2019
@lieut-data lieut-data added this to the v5.16.0 milestone Aug 6, 2019
@lindalumitchell
Copy link
Contributor

QA review not needed pre-merge. Removing QA Review label.

@lindalumitchell lindalumitchell removed the 3: QA Review Requires review by a QA tester label Aug 6, 2019
@jasonblais jasonblais changed the title Remove ambiguity on LDAP and SAML System Console help texts MM-17517 Remove ambiguity on LDAP and SAML System Console help texts Aug 6, 2019
@jasonblais jasonblais added the 4: Reviews Complete All reviewers have approved the pull request label Aug 6, 2019
@jasonblais
Copy link
Contributor Author

@hanzei or @lieut-data - this one is ready to merge, thanks!

@hanzei hanzei self-assigned this Aug 6, 2019
@hanzei hanzei merged commit f319fd6 into master Aug 6, 2019
@hanzei hanzei deleted the jasonblais-patch-3 branch August 6, 2019 15:41
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 19, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Sep 20, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jasonblais @skheria
MM-17517 Remove ambiguity on LDAP and SAML System Console help texts (m…
3b8bfd4 
…attermost#3362)
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jasonblais @skheria
MM-17517 Remove ambiguity on LDAP and SAML System Console help texts (m…
2730693 
…attermost#3362)
@hanzei hanzei removed their assignment Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@wiersgallak wiersgallak wiersgallak approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jasonblais @lindalumitchell @lieut-data @wiersgallak @lindy65 @hanzei @amyblais