explicitly check contentType of reference before downloading files #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
force-pushed
the
mm-59273-improve-attachment-handling
branch
from
ceeef26
to
85f1165
Compare
JulienTant
approved these changes
Jul 17, 2024
sbishel
approved these changes
Jul 17, 2024
| @@ -152,6 +152,13 @@ func (ah *ActivityHandler) handleAttachments(channelID, userID, text string, msg | |||
| continue | |||
| } | |||
|
|
|||
| // The rest of the code assumes a (file) reference: ignore other content types until we explicitly support them. | |||
| if a.ContentType != "reference" { | |||
There was a problem hiding this comment.
Suggestion for future cleanup. Move all the "ContentType" strings to constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly check for a
contentTypeofreferencebefore trying to process the attachment as a file attachment.Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-59273