support file attachments for chat notifications #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
force-pushed
the
mm-58485-support-file-attachments-for-notifications
branch
from
b6f1376
to
4e4e1c9
Compare
lieut-data
force-pushed
the
mm-58485-support-file-attachments-for-notifications
branch
from
4e4e1c9
to
c8e802a
Compare
…-attachments-for-notifications
…-attachments-for-notifications
sbishel
approved these changes
Jun 19, 2024
|
@calebroseland, adding you as a last minute reviewer -- is there a chance you might have bandwidth to help review this for tomorrow? |
JulienTant
approved these changes
Jun 19, 2024
|
Ah, thank you @JulienTant! |
lieut-data
added
the
4: Reviews Complete
lieut-data
deleted the
mm-58485-support-file-attachments-for-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include file attachments from chat messages when notifying users via one-way sync:
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-58485