Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-58344: style notifications #667

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

lieut-data
Copy link
Member

Summary

Update the styling of notifications for messages received. While we're in here, rewrite TestHandleCreatedActivity using the new framework and add coverage for notifications.

DM
CleanShot 2024-05-22 at 17 37 54@2x

GM, multiple lines
CleanShot 2024-05-22 at 17 37 59@2x

GM, code block
CleanShot 2024-05-22 at 17 38 05@2x

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-58344

@lieut-data lieut-data added the 2: Dev Review Requires review by a core committer label May 22, 2024
Copy link
Member

@JulienTant JulienTant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lieut-data

@lieut-data lieut-data merged commit 6cfdd81 into main May 23, 2024
9 checks passed
@lieut-data lieut-data deleted the mm-58344-style-notifications branch May 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants