Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(typo) botUsertID => botUserID #644

Merged
merged 1 commit into from
May 8, 2024
Merged

(typo) botUsertID => botUserID #644

merged 1 commit into from
May 8, 2024

Conversation

JulienTant
Copy link
Member

Summary

fix typo 😅

@JulienTant JulienTant requested a review from lieut-data May 8, 2024 15:12
@JulienTant JulienTant added the 2: Dev Review Requires review by a core committer label May 8, 2024
@JulienTant JulienTant requested a review from sbishel May 8, 2024 15:12
@JulienTant JulienTant enabled auto-merge (squash) May 8, 2024 15:12
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who reviewed the original PR? 😳

@JulienTant JulienTant merged commit d8fe327 into main May 8, 2024
5 of 6 checks passed
@JulienTant JulienTant deleted the typo/botuserid branch May 8, 2024 15:16
@JulienTant
Copy link
Member Author

So for future reference, the Github automerge feature does not wait for the "checks" (lint, ci..) to be over, just reviews :|

@lieut-data
Copy link
Member

So for future reference, the Github automerge feature does not wait for the "checks" (lint, ci..) to be over, just reviews :|

Ah, I wonder if we just need to mark these checks as required for this to happen. Let me try that if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants