Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57975 - only display message if user is connected #624

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

sbishel
Copy link
Member

@sbishel sbishel commented Apr 24, 2024

Summary

When the user changes their "primary" platform, we display a bot message. We also implemented a fix that resets the users primary platform back to Mattermost upon disconnect. This resulted in the bot message whenever /msteams disconnect was run.

This PRs as a check for the user being active and only showing the message if the user is active.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-57975

@sbishel sbishel changed the title only display message if user is connected MM-57975 - only display message if user is connected Apr 24, 2024
@sbishel sbishel marked this pull request as ready for review April 25, 2024 19:49
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sbishel! Would you consider rebasing this on #623 and then updating those tests to reflect this new requirement?

@sbishel
Copy link
Member Author

sbishel commented Apr 25, 2024

#623 is required for the new tests to pass.

@sbishel sbishel added the QA/Deferred Agreement with QA that these changes will be tested post-merge label Apr 29, 2024
@sbishel sbishel merged commit 887b732 into main Apr 29, 2024
7 checks passed
@sbishel sbishel deleted the MM-57975-disconnect branch April 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/Deferred Agreement with QA that these changes will be tested post-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants