[MM-57821] Reduce number of calls to GetUser in syncUsers #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienTant
added
2: Dev Review
lindy65
added
QA/Deferred
lindy65
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks @JulienTant - I've QA-deferred and will test post-merge
enahum
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are calling GetUser for each synthetic during the syncUsers job, but we only need to make this call if autopromote is
on.Reminder: the reason why we need this call is because
GetUsersdoes not returnAuthData: it's sanitized, so we makeGetUserto get this info. Ideally, plugins should have access to more unsanitized data, but it involves a much heavier change on mattermost server, getting security validation etc... the change is probably not worth investing time in right now.I don't expect this PR to have a significant positive perf impact as Jesus believes that
GetUseris pulling data from cache rather than DB, but it's probably still better to only do the call when needed rather than all the time.QA
I think for QA, just making sure that the syncUsers job will works as before is the best way to go
Ticket Link
https://mattermost.atlassian.net/browse/MM-57821