Add DB replica support #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
added
4: Reviews Complete
|
@jespino @mgdelacroix @wiggin77 are we ok merging this one ? |
wiggin77
reviewed
May 6, 2024
server/store/sqlstore/migrations.go
Outdated
| @@ -37,7 +37,7 @@ const ( | |||
|
|
|||
| func (s *SQLStore) runMSTeamUserIDDedup() error { | |||
| // get all users with duplicate msteamsuserid | |||
| rows, err := s.getQueryBuilder().Select( | |||
| rows, err := s.getMasterQueryBuilder().Select( | |||
There was a problem hiding this comment.
Why is master needed here for a SELECT?
There was a problem hiding this comment.
@wiggin77 I assumed is needed as this is a migration to avoid any sort of lag. I can change it to use the replica if you think is best
There was a problem hiding this comment.
I'll change it to use the replica and then merge.. if this causes issues we can always switch to use master again
wiggin77
approved these changes
May 6, 2024
|
/update-branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Database read replica support when available
Ticket Link
https://mattermost.atlassian.net/browse/MM-57139