MM-57565 - Set root id if it exists on attachment sync warning #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
changed the title
calebroseland
approved these changes
Apr 16, 2024
Before removing the new post displayed before the origin in the threaded view. Not sure why it was being set anyway. It should its own and correct createAt, shouldn't it? |
sbishel
added
the
QA/Deferred
|
Will QA during bug bash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set the rootID for the new post to the existing posts root id. Result is if null, new post displays in center section and if a reply it will appear in the thread list.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-57565