[MM-56867] Fix metrics by not counting disabled users #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
approved these changes
Mar 26, 2024
sbishel
pushed a commit
that referenced
this pull request
Apr 2, 2024
* stop counting disabled msteams user * fix terminology * fix test + lint
sbishel
added a commit
that referenced
this pull request
Apr 8, 2024
* add handling for connecting bot account * check for permissions and connected user * add more tests * Update api_test.go * update Grafana dashboard for Cloud, stripping out hard-coded links (#557) * Disable temporoarily auto share DMs (#558) * [MM-56908] Make promote command accepts @ for both arguments (#550) * [MM-57072] Use ConstantTimeCompare to prevent timing attack (#549) * use ConstantTimeCompare to prevent timing attack * document code * MM-57367: log when invite sent (#559) * log when invite sent * remove listener on uninitialize * review change * use IsGroupOrDirect for clarity (#556) * [MM-57209] Set EmailVerified to true when promoting synthetic users (#548) * Set EmailVerified to true when promoting synthetic users * change EmailVerified in the sync job + add and fix tests * add once * lint * add EmailVerified when creating synthetic user from a getter * remove EmailVerified from the getOrCreateSyntheticUser (not promoted there) * fix tests * MM-57120: show connected users stat (#571) Show the number of connected users on the system console for administrators. Fixes: https://mattermost.atlassian.net/browse/MM-57350 * [RE:MM-57209] Set EmailVerified to true when autopromoting through hook (#565) * MM-57120: delay monitoring job on startup (#570) Delay the monitoring job by at least 1 minute after startup to avoid a race where the plugin hasn't fully yet deployed in a mostly disabled environment. ``` { "timestamp": "2024-03-30 15:06:00.011 -03:00", "level": "info", "msg": "Delaying the Monitoring System Job until at least 1 minute after startup", "caller": "app/plugin_api.go:1004", "plugin_id": "com.mattermost.msteams-sync" } { "timestamp": "2024-03-30 15:07:00.016 -03:00", "level": "info", "msg": "Running the Monitoring System Job", "caller": "app/plugin_api.go:1004", "plugin_id": "com.mattermost.msteams-sync" } ``` Fixes: https://mattermost.atlassian.net/browse/MM-57120 * [MM-56867] Fix metrics by not counting disabled users (#561) * stop counting disabled msteams user * fix terminology * fix test + lint * MM-56809: support deleting messages from Mattermost (#569) --------- Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Jesús Espino <jespinog@gmail.com> Co-authored-by: Julien Tant <785518+JulienTant@users.noreply.github.com> Co-authored-by: Caleb Roseland <caleb@calebroseland.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
msteams_connect_app_upstream_usersalso counts MSTeams accounts that are not enabled. This PR fixes thisTicket Link
Partially fixes https://mattermost.atlassian.net/browse/MM-56887