Improve Users sync #545
Merged
Improve Users sync #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JulienTant, adding you as reviewer as part of helping to own all things synthetic users. Happy to chime in as needed -- feel free to ping me! |
|
I was reviewing the PR and accidentally committed and pushed fixes for something else here 😓 reverted now, sorry for the noise! |
JulienTant
approved these changes
Mar 18, 2024
jespino
added
4: Reviews Complete
|
@enahum there is a conflict, but other than that looks good to me. |
|
@jespino can you help look into why the tests are failing? |
|
@enahum I reran the job and everything went green! :) |
lieut-data
pushed a commit
that referenced
this pull request
Apr 4, 2024
* refactor syncUser * skip user creation if they are deactivated on msTeams * add EmailVerified when creating synthetic user from a getter * Revert "add EmailVerified when creating synthetic user from a getter" This reverts commit 1d2a69c. * fix bad merge * disable selectiveSync test --------- Co-authored-by: Julien Tant <julien@craftyx.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor syncUsers so it reads better and fixes the issue where users being activated and deactivated constantly.
We now do not create synthetic users if they are not present in MM but disabled on MS Teams
Ticket Link
https://mattermost.atlassian.net/browse/MM-56942
https://mattermost.atlassian.net/browse/MM-56886