MM-56469 - change out library for converting html to markdown. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
added
2: Dev Review
|
@esarafianou - Not sure if security wants to review now or with the plugin as a whole later.... |
sbishel
changed the title
lieut-data
approved these changes
Feb 29, 2024
hmhealey
approved these changes
Feb 29, 2024
esarafianou
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM.
cc. @jupenur let me know if you'd like to have an extra look at the new library.
sbishel
removed
2: Dev Review
lindy65
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes out the library used for converting HTML to Markdown. Also implements unit test for all the potential conversions we support...if any were missed, let's add them.
http://github.com/JohannesKaufmann/html-to-markdown
The prior library did not handle tables without a
THEADvery well, tables create in MS Teams do not have this row. This library creates GibHub Flavored Markdown and is extensible via Plugins.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-56469