fix closeInfoPage to call on promise resolution #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I regressed the behaviour, which closed the window before the promise was resolved. In my case, since the window never actually closed, the fetch had a chance to succeed. On browsers that honoured `window.close`, the `fetch` was interrupted and the settings never saved.
calebroseland
approved these changes
Feb 21, 2024
lieut-data
added
QA/Deferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I regressed the behaviour, which closed the window before the promise was resolved. In my case, since the window never actually closed, the fetch had a chance to succeed. On browsers that honoured
window.close, thefetchwas interrupted and the settings never saved.Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-56967