Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments for commented out features #499

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Remove comments for commented out features #499

merged 2 commits into from
Feb 16, 2024

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Feb 13, 2024

Summary

Remove comments about the commented out features:

  • Landing page after connect to select primary platform
  • User setting to select primary platform

Ticket Link

Fix: https://mattermost.atlassian.net/browse/MM-56856

@larkox larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 13, 2024
@larkox
Copy link
Contributor Author

larkox commented Feb 13, 2024

@hmhealey If you prefer me to base this on your PR, let me know, but I thought it was ok to just send it to master.

@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (a844340) 41.50% compared to head (e48f990) 41.34%.

Files Patch % Lines
server/api.go 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   41.50%   41.34%   -0.16%     
==========================================
  Files          22       22              
  Lines        6113     6136      +23     
==========================================
  Hits         2537     2537              
- Misses       3362     3385      +23     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core committer label Feb 15, 2024
@lieut-data lieut-data added QA/Deferred Agreement with QA that these changes will be tested post-merge and removed 3: QA Review Requires review by a QA tester labels Feb 16, 2024
@lieut-data lieut-data added this to the v1.8.0 milestone Feb 16, 2024
@lieut-data
Copy link
Member

Let's QA this as part of the whole release.

@lieut-data lieut-data merged commit d2f1314 into main Feb 16, 2024
7 checks passed
@lieut-data lieut-data deleted the removeComments branch February 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/Deferred Agreement with QA that these changes will be tested post-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants