Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-3650] Added the metric for MS Graph client method time #371

Merged
merged 38 commits into from
Oct 25, 2023
Merged

[MI-3650] Added the metric for MS Graph client method time #371

merged 38 commits into from
Oct 25, 2023

Conversation

manojmalik20
Copy link
Collaborator

Summary

  • Created a new package called clientmodels and moved all the structs to that
  • Made necessary changes across the project related to the new package
  • Created a new timer layer over the client package using a timer_layer.go.tmpl
  • Added go generate commands to generate the timer layer over the client package
  • Modified the OnActivate hook and GetClient methods to use the timerlayer wrapper over the original client
  • Added new histogram metric for measuring the time taken by a client method
  • Fixed some of the failing unit tests

Ticket Link

None

ayusht2810 and others added 20 commits October 18, 2023 16:11
@ayusht2810
[MI-3624] Add some additional metrics
8788616
@ayusht2810
[MI-3624] Remove extra comments
9e4298d
@ayusht2810
Merge branch 'main' of github.com:mattermost/mattermost-plugin-msteam…
f57a0f6 
…s-sync into MI-3624
@ayusht2810
[MI-3624] Fix testcases
6406197
@ayusht2810
[MI-3642] Add metrics to count upstream users
5c9dffd
@ayusht2810
[MI-3643] Add metrics to show messages confirmed count
4a75b85
@ayusht2810
[MI-3624] Update variable names and add new
939a058
@ayusht2810
[MI-3644] Add metrics of subscription count for different actions
a2c750e
@ayusht2810
[MI-3644] Revert extra changes
4a9e5d1
@manojmalik20
[MI-3646] Added metrics for MS Graph API time
8b9a011 
Modified the client struct to include metricsService and did required changes in all the files
Added a go generate comment for Metrics interface
Created a middleware for MS Graph to measure the time taken by the MS Graph API
Changed the way of creating the app based and token based clients for MS Graph
@ayusht2810
Merge branch 'main' of github.com:mattermost/mattermost-plugin-msteam…
8388f5c 
…s-sync into MI-3624
@ayusht2810
[MI-3624] Update function, added util and minor review fixes
9a4f727
@ayusht2810
[MI-3644] Update help text
4a66aa0
@manojmalik20
[MI-3646] Did some refactoring and fixed failing lint checks
41e1fe5
@ayusht2810
[MI-3624] Reuse constants from other packages
6628939
@ayusht2810
[MI-3642] Add comments in metrics interface
7ac96b9
@ayusht2810
Merge branch 'MI-3624' of github.com:mattermost/mattermost-plugin-mst…
9ddcb34 
…eams-sync into MI-3642
@ayusht2810
Merge branch 'MI-3642' of github.com:mattermost/mattermost-plugin-mst…
cb2e025 
…eams-sync into MI-3643
@ayusht2810
Merge branch 'MI-3643' of github.com:mattermost/mattermost-plugin-mst…
5ed51db 
…eams-sync into MI-3644
@manojmalik20
[MI-3650] Added the metric for MS Graph client method time
05e6988 
Created a new package called clientmodels and moved all the structs to that
Made necessary changes across the project related to the new package
Created a new timer layer over the client package using a timer_layer.go.tmpl
Added go generate commands to generate the timer layer over the client package
Modified the OnActivate hook and GetClient methods to use the timerlayer wrapper over the original client
Added new histogram metric for measuring the time taken by a client method
Fixed some of the failing unit tests
ayusht2810
ayusht2810 reviewed Oct 24, 2023
View reviewed changes
server/message_hooks_test.go Outdated Show resolved Hide resolved
server/message_hooks_test.go Outdated Show resolved Hide resolved
server/message_hooks_test.go Outdated Show resolved Hide resolved
server/metrics/metrics.go Show resolved Hide resolved
server/msteams/layer_generators/main.go Outdated Show resolved Hide resolved
server/msteams/layer_generators/main.go Outdated Show resolved Hide resolved
server/msteams/layer_generators/main.go Show resolved Hide resolved
server/msteams/layer_generators/main.go Outdated Show resolved Hide resolved
@manojmalik20 manojmalik20 added Difficulty/3:Hard Hard ticket Test Cases Includes unit test cases changes labels Oct 24, 2023
ayusht2810
ayusht2810 approved these changes Oct 24, 2023
View reviewed changes
server/metrics/metrics.go Show resolved Hide resolved
lieut-data
lieut-data approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @manojmalik20!

jespino
jespino approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manojmalik20 manojmalik20 changed the base branch from MI-3646 to main October 25, 2023 08:06
@manojmalik20 manojmalik20 merged commit 083bbfd into main Oct 25, 2023
1 check passed
@manojmalik20 manojmalik20 deleted the MI-3650 branch October 25, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@lieut-data lieut-data lieut-data approved these changes

@jespino jespino jespino approved these changes

Assignees
No one assigned
Labels
Difficulty/3:Hard Hard ticket Test Cases Includes unit test cases changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manojmalik20 @jespino @lieut-data @ayusht2810