Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding initial infrestructure for metrics #306

Merged
merged 17 commits into from
Sep 15, 2023
Merged

Adding initial infrestructure for metrics #306

merged 17 commits into from
Sep 15, 2023

Conversation

jespino
Copy link
Member

@jespino jespino commented Sep 13, 2023

No description provided.

lieut-data
lieut-data requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast @jespino! Just a few things I spotted.

server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/store/store.go Outdated Show resolved Hide resolved
@lieut-data
Copy link
Member

re: Removing unneeded metrics, are we sure we don't want these @jespino? Given this is a discrete Go process, I wonder if it's still useful?

@jespino
Copy link
Member Author

jespino commented Sep 13, 2023

re: Removing unneeded metrics, are we sure we don't want these @jespino? Given this is a discrete Go process, I wonder if it's still useful?

Good point, I'll revert that.

@jespino
Copy link
Member Author

jespino commented Sep 13, 2023

This is still a bit "draft", I have to do some changes and test it locally.

@jespino
Copy link
Member Author

jespino commented Sep 14, 2023

@lieut-data @manojmalik20 I still have to fix the tests (some extra mock calls and things like that), and add some tests to the new store function, but apart from that, this is ready for review.

lieut-data
lieut-data requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @jespino! Just a few clarifying questions / comments.

server/api.go Outdated Show resolved Hide resolved
server/metrics/metrics.go Outdated Show resolved Hide resolved
server/api.go Outdated Show resolved Hide resolved
server/msteams/client.go Outdated Show resolved Hide resolved
lieut-data
lieut-data approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jespino!

manojmalik20
manojmalik20 reviewed Sep 14, 2023
View reviewed changes
server/api.go Outdated Show resolved Hide resolved
server/metrics/metrics.go Outdated Show resolved Hide resolved
server/metrics/service.go Outdated Show resolved Hide resolved
server/middleware.go Outdated Show resolved Hide resolved
@jespino
Copy link
Member Author

jespino commented Sep 14, 2023

@manojmalik20 PTAL

@jespino @lieut-data
Update server/metrics/metrics.go
ed8d905 
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
@jespino
Copy link
Member Author

jespino commented Sep 14, 2023

@manojmalik20 feel free to merge it after your review is done. CI is passing, and it is working in my environment.

@manojmalik20 manojmalik20 merged commit 97a837a into main Sep 15, 2023
1 check passed
@manojmalik20 manojmalik20 deleted the metrics branch September 15, 2023 08:21
@ayusht2810 ayusht2810 mentioned this pull request Sep 22, 2023
Merged
@lieut-data lieut-data mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@manojmalik20 manojmalik20 manojmalik20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jespino @lieut-data @manojmalik20