[MM-55223] add basic dump mechansim #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 13.59% 13.11% -0.48%
==========================================
Files 6 8 +2
Lines 456 686 +230
==========================================
+ Hits 62 90 +28
- Misses 385 580 +195
- Partials 9 16 +7 ☔ View full report in Codecov by Sentry. |
|
The interval selection screen is something like this: Screen.Recording.2024-01-09.at.21.36.45.mov |
agnivade
reviewed
Jan 15, 2024
agnivade
approved these changes
Jan 16, 2024
cpoile
approved these changes
Jan 16, 2024
Comment on lines
+71
to
+72
| if ok, err := b.FileExists(src); !ok { | ||
| return nil |
There was a problem hiding this comment.
Not sure if it's important, but it's possible for FileExists to return false with a "unable to know if file %s exists` error, but then we wouldn't return the error here -- is that ok?
There was a problem hiding this comment.
Good point, it's actually okay as we will continue to the loop where we call the copy function.
isacikgoz
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP: Create a tsdb dump and write zip file to the remote storage
Ticket Link
https://mattermost.atlassian.net/browse/MM-55223