[MM-55224] convert plugin config to scraper config

[isacikgoz]

Summary

Convert plugin config to scraper config

Ticket Link

https://mattermost.atlassian.net/browse/MM-55224

[agnivade]

Should we also impose a max body size limit?

[isacikgoz]

Hmm, we can do that. Ideally it should be unbounded as we are unaware of possible sample size but for our case we can forecast.

[agnivade]

I think we should have some limit as a config for customers to enforce. We can have some large value as default, but it'd be good to allow customers to set some limit as their preference.

[isacikgoz]

I'll add that check for the next PR

[agnivade]

Why do we have to disable typecheck though? I've never seen a need for that. Just curious.

[isacikgoz]

Why do we have to disable typecheck though? I've never seen a need for that. Just curious.

There were quite a lot false positives, you can check: https://github.com/mattermost/mattermost-plugin-metrics/actions/runs/7207283664/job/19634510528

I am not sure how it started to happen as they are all unrelated. Tried with the newer version of golangci-lint, but it was all okay. Searched the issues but couldn't find a good explanation. Only a issue related the false positives. Attached it to the .golangci-lint.yml file.

[agnivade]

This

Error: server/configuration.go:159:20: p.API undefined (type *Plugin has no field or method API) (typecheck)
	serverConfig := p.API.GetConfig()
	                  ^
Error: server/configuration.go:161:5: p.API undefined (type *Plugin has no field or method API) (typecheck)
		p.API.LogError("OnConfigurationChange: failed to get server config")
		  ^
Error: server/configuration.go:175:14: p.API undefined (type *Plugin has no field or method API) (typecheck)
	if err := p.API.LoadPluginConfiguration(cfg); err != nil {

looks like a setup issue for sure. Somewhere, it's not able to compile the code correctly.

[isacikgoz]

I tired to build it was compiling but something with the golangci-lint not being able to parse correctly. And it was not complaining until I fixed a spelling error :)

[hanzei]

That is a CI issue. @fmartingr is working on it: mattermost/actions-workflows#38