Implement new support packet API #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isacikgoz
added
1: PM Review
agnivade
reviewed
Apr 30, 2024
agnivade
reviewed
Jun 4, 2024
| } | ||
| defer fr.Close() | ||
|
|
||
| b, err := io.ReadAll(fr) |
There was a problem hiding this comment.
Are we sure this won't cause OOM issues? Ideally we should stream the file contents downstream right?
There was a problem hiding this comment.
Yes, there is a small possibility but this was how the API being implemented, we need to change the API to accept something like a io.ReaderCloser. However or in our case; ideally server can directly read from the filestore but still the API needs to be changed.
There was a problem hiding this comment.
Ok, wondering if we should file a ticket to track this? For example, k8s pods have a mem limit to them. There could be cases where this might be problematic. I'll approve for now but we should probably have a streaming API.
agnivade
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can now safely use new support packet API.