Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PRR feedback #19

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Apply PRR feedback #19

merged 6 commits into from
Mar 12, 2024

Conversation

isacikgoz
Copy link
Member

Summary

This PR addresses the non-blocking feedback received from the PRR:

Included:

  • Adds codeql analysis.
  • Update node version in .nvmrc.
  • Limit the build to only Linux as linux_amd64 and linux_arm64.
  • Fixes a type at config.json where desginated should bedesignated.

Not included:

  • I'll update the default branch to main instead of master after this PR goes in.
  • The min server requirement should be v6.3, that's accurate.

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Mar 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.15%. Comparing base (d433977) to head (c444cf7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   11.15%   11.15%           
=======================================
  Files           9        9           
  Lines         789      789           
=======================================
  Hits           88       88           
  Misses        686      686           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isacikgoz!

(needs to look at the failing job)

@isacikgoz isacikgoz added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 12, 2024
@isacikgoz isacikgoz merged commit 2feeb73 into master Mar 12, 2024
4 checks passed
@isacikgoz isacikgoz deleted the prr-feedback branch March 12, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants