Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send event if there are no commits #85

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Don't send event if there are no commits #85

merged 3 commits into from
Aug 21, 2019

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Aug 9, 2019

No description provided.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 9, 2019
@hanzei hanzei requested a review from manland August 9, 2019 11:06
@hanzei hanzei requested a review from cpoile August 9, 2019 19:35
@hanzei hanzei changed the title Don't event event if there are no commits Don't send event if there are no commits Aug 9, 2019
@cpoile cpoile added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Aug 12, 2019
@hanzei
Copy link
Collaborator Author

hanzei commented Aug 12, 2019

@cpoile Do you think this need QA review? If so, would you please request a review.

@cpoile
Copy link
Member

cpoile commented Aug 12, 2019

@hanzei Yep, as I understand it everything needs QA review now (unless it's super minor).

@lindalumitchell
Copy link

Is this related to a JIRA ticket / is there info about what to test? Which release is this expected to go into (v5.16)?

@hanzei
Copy link
Collaborator Author

hanzei commented Aug 12, 2019

Is this related to a JIRA ticket / is there info about what to test?

Not really. I stumbled across this bug, but don't know how to repo it.

Which release is this expected to go into (v5.16)?

That not up to me to decide. But given it's a very minor fix, I would like to see it in 5.14.

@DHaussermann
Copy link

@aaronrothschild Please note that we are finishing a release for GitLab now and this PR was not included. Please advise if you feel this is required.

@aaronrothschild
Copy link

@aaronrothschild Please note that we are finishing a release for GitLab now and this PR was not included. Please advise if you feel this is required.

How does this bug manifest itself? What is this bug fixing?

@hanzei
Copy link
Collaborator Author

hanzei commented Aug 13, 2019 •
edited
Loading

@aaronrothschild When a users pushes to a repo, but doesn't add new commits, the message X has pushed 0 commit Y would be shown. To me this doesn't show meaningful information. Hence this PR fixes this by not showing any message if this happens.

@cpanato
Copy link
Contributor

cpanato commented Aug 14, 2019

/check-cla

@hanzei
Copy link
Collaborator Author

hanzei commented Aug 21, 2019

@DHaussermann @aaronrothschild Can we merge this?

DHaussermann
DHaussermann approved these changes Aug 21, 2019
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @hanzei please merge this. I'm okay with testing this change from Master branch.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 21, 2019
@hanzei hanzei merged commit 4990fd6 into master Aug 21, 2019
@hanzei hanzei deleted the stip_commits branch August 21, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@manland manland manland approved these changes

@cpoile cpoile cpoile approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hanzei @cpoile @lindalumitchell @DHaussermann @aaronrothschild @cpanato @manland