[MM-176] Sync the plugin with starter template #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Signed-off-by: ayusht2810 <ayush.thakur@brightscout.com>
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
mickmister
approved these changes
Feb 1, 2024
Comment on lines
+184
to
+191
| ### Releasing new versions | ||
|
|
||
| The version of a plugin is determined at compile time, automatically populating a `version` field in the [plugin manifest](plugin.json): | ||
| * If the current commit matches a tag, the version will match after stripping any leading `v`, e.g. `1.3.1`. | ||
| * Otherwise, the version will combine the nearest tag with `git rev-parse --short HEAD`, e.g. `1.3.1+d06e53e1`. | ||
| * If there is no version tag, an empty version will be combined with the short hash, e.g. `0.0.0+76081421`. | ||
|
|
||
| To disable this behaviour, manually populate and maintain the `version` field. |
There was a problem hiding this comment.
Interesting. So you can no longer inspect plugin.json to see what version a plugin is at
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Synced the plugin to include the below PRs:
Ticket Link