-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-320] Added config setting to enable/disable child pipeline notification #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
October 11, 2023 10:12
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 32.91% 33.08% +0.17%
==========================================
Files 22 22
Lines 4017 4020 +3
==========================================
+ Hits 1322 1330 +8
+ Misses 2564 2559 -5
Partials 131 131
☔ View full report in Codecov by Sentry. |
raghavaggarwal2308
changed the title
[MI-3589] Added config setting to enable/disable child pipeline notfication
[MM-320] Added config setting to enable/disable child pipeline notification
Oct 11, 2023
Kshitij-Katiyar
approved these changes
Oct 12, 2023
Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com>
mickmister
approved these changes
Oct 13, 2023
hanzei
requested review from
AayushChaudhary0001
and removed request for
spirosoik
November 29, 2023 12:17
AayushChaudhary0001
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved
Working fine for both "True" and "False" condition, LGTM.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a pipeline with many child pipelines is triggered on Gitlab and the user has a subscription for "pipeline" in a channel, the channel gets flooded with many notifications. We added a config setting to enable/disable notification for child pipelines.
Screenshots
When enabled:
When disabled:
What to test?
EnableChildPipelineNotifications
is disabled.Steps to reproduce:
Environment:
MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0
Ticket Link
Fixes #320