-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-400] Display proper message for access request todo #404
Conversation
* [MI-3515] Display proper message for access request todo * [MI-3515] Review fix
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 32.91% 32.86% -0.05%
==========================================
Files 22 22
Lines 4017 4022 +5
==========================================
Hits 1322 1322
- Misses 2564 2569 +5
Partials 131 131
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just some naming suggestions
@mickmister Fixed the review comments mentioned by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved, LGTM
Summary
The description of the "member_access_requested" todo was not being displayed, we handled the case specifically and added a proper description.
Screenshots
Earlier:
Now:
What to test:
Steps to reproduce:
/gitlab todo
command on Mattermost. You should get a post containing the todos.Expected behavior:
Environment:
GitLab Plugin version: 1.7.0
MM version: v7.8.2
Ticket Link
Fixes #400