Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-400] Display proper message for access request todo #404

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

The description of the "member_access_requested" todo was not being displayed, we handled the case specifically and added a proper description.

Screenshots

Earlier:
image

Now:
image

What to test:

  • Todos are properly displayed for "member_access_requested".
Steps to reproduce:
  1. Connect your Gitlab account.
  2. Request access to one of your projects/groups from any other user. You will get a todo/notification on Gitlab for access request.
  3. Run the /gitlab todo command on Mattermost. You should get a post containing the todos.
Expected behavior:
  • The "member_access_requested" todo should have a proper description.
Environment:

GitLab Plugin version: 1.7.0
MM version: v7.8.2

Ticket Link

Fixes #400

* [MI-3515] Display proper message for access request todo

* [MI-3515] Review fix
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7190bfd) 32.91% compared to head (3fa37a3) 32.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   32.91%   32.86%   -0.05%     
==========================================
  Files          22       22              
  Lines        4017     4022       +5     
==========================================
  Hits         1322     1322              
- Misses       2564     2569       +5     
  Partials      131      131              
Files Coverage Δ
server/plugin.go 14.28% <0.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just some naming suggestions

server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Sep 26, 2023
@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Fixed the review comments mentioned by you.

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved, LGTM

@mickmister mickmister merged commit 90ed135 into mattermost:master Nov 28, 2023
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the fix_issue_400 branch November 29, 2023 07:02
@avas27JTG avas27JTG mentioned this pull request Nov 29, 2023
@avas27JTG avas27JTG added this to the v1.8.0 milestone Nov 29, 2023
@mickmister mickmister mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily reminder "unread messages" shows blank todo with member_access_requested
4 participants