Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.1.0 #131

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Bump version to v1.1.0 #131

merged 1 commit into from
Jan 23, 2020

Conversation

jfrerich
Copy link
Contributor

Bump version to v1.1.0

Bumped Minor version because new features added.

@jfrerich jfrerich requested review from levb and hanzei January 14, 2020 15:36
@jfrerich jfrerich added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 14, 2020
@jfrerich jfrerich added the 1: PM Review Requires review by a product manager label Jan 14, 2020
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfrerich
Copy link
Contributor Author

@levb, the link you provided is 404, for me. When I traverse to more -> Security I don't see any alerts.

@jfrerich
Copy link
Contributor Author

jfrerich commented Jan 14, 2020

@levb, I am not an approved admin for this repo and cannot perform the security updates.

@crspeller mentioned npm audit fix was the manual method to update. For the security update documentation, I'd like to compare the results of dependabot changes vs the manual method. npm audit fix produces >20 changed dependencies.

Can someone please produce the dependabot PR, or provide admin permissions? For documentation purposes, I'd like to accompany the process so I can document the process and take snapshots.

@levb
Copy link
Contributor

levb commented Jan 15, 2020

@jfrerich I have given you the access to security alerts on this repo, you should be able to see it now.

@DHaussermann
Copy link

GitLab was End to End tested for this release and version bump was successful.

@jfrerich let's follow up once you can provide details of the linked issue to see what other testing may be needed.

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Jan 21, 2020
@jfrerich jfrerich requested a review from levb January 23, 2020 20:24
@jfrerich
Copy link
Contributor Author

@DHaussermann the other linked issue just got merged. #132

It was a dependency to update some security issues (required before bumping this version.

@levb the dependency issues have been addressed and merged and this is ready for re-review! Thanks guys!

@levb levb removed the 2: Dev Review Requires review by a core committer label Jan 23, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above GitLab was End to End tested for this release and version bump was successful.
No further code changes on this PR
LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 23, 2020
@crspeller crspeller merged commit 6a4691e into master Jan 23, 2020
@crspeller crspeller deleted the bump-version-v1.1.0 branch January 23, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants